Open
refactor: split logs_orchestrator.go (1284 lines) into 5 focused modules#44051
Conversation
9 tasks
- Extract types into logs_orchestrator_types.go (87 lines) - Extract filter logic and ProcessedRun builder into logs_orchestrator_filters.go (184 lines) including new applyRunFilters and buildProcessedRun helpers that eliminate ~250 lines of duplication - Extract rendering into logs_orchestrator_render.go (158 lines) - Extract stdin processing into logs_orchestrator_stdin.go (229 lines) - Trim logs_orchestrator.go from 1284 to 603 lines - Add logs_orchestrator_filters_test.go with tests for new helpers Closes #44036 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor logs_orchestrator.go into focused modules
refactor: split logs_orchestrator.go (1284 lines) into 5 focused modules
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pkg/cli/logs_orchestrator.gohad grown to 1284 lines mixing orchestration, filter logic, type definitions, output rendering, and stdin processing — with ~150 lines of run-filter andProcessedRunconstruction duplicated betweenDownloadWorkflowLogsandDownloadWorkflowLogsFromStdin.Changes
logs_orchestrator_types.go(87 lines) — pure type declarations:LogsDownloadOptions,StdinLogsOptions,continuationOptions,renderLogsOutputOptionslogs_orchestrator_filters.go(184 lines) — filter logic with two new shared helpers:applyRunFilters(result, opts, verbose) bool— consolidates engine / staged / firewall / safe-output / DIFC filter blocks that were duplicated across both download pathsbuildProcessedRun(result, verbose) ProcessedRun— consolidatesProcessedRun{...}construction (duration, action minutes, effective tokens, job counts)logs_orchestrator_render.go(158 lines) —renderLogsOutput+renderLogsArtifactHintlogs_orchestrator_stdin.go(229 lines) —DownloadWorkflowLogsFromStdinlogs_orchestrator.gotrimmed from 1284 → 603 lines; retains only the pagination loop,DownloadWorkflowLogs, and small utilitieslogs_orchestrator_filters_test.go— unit tests forapplyRunFiltersandbuildProcessedRunExample: deduplicated filter call
Before (identical block existed in both
DownloadWorkflowLogsandDownloadWorkflowLogsFromStdin, ~80 lines each):After (one call, both paths):
Public API (
DownloadWorkflowLogs,DownloadWorkflowLogsFromStdin,LogsDownloadOptions,StdinLogsOptions) is unchanged.