Allow newer versions of assert#266
Merged
Merged
Conversation
Member
Author
Member
Author
|
No idea what these test errors are, appears to be long standing. |
|
@shadowhand test failed because it installs deps with ignoring platform deps on PHP 8.1 |
Member
Author
|
Oh yeah, that won't work with assert v2, it requires newer PHP. |
Member
Author
|
Fix for CI in #267. |
Member
|
@shadowhand I've merged the other PR, could you rebase? |
shadowhand
force-pushed
the
chore/allow-new-assert
branch
from
6fd46a3 to
2420c79
Compare
Member
Author
|
@frankdejonge done. |
|
Great news ;-) |
Member
Author
|
@frankdejonge can this be merged and released now? |
|
When is this planned to be merged and released? |
|
Hey @lezhnev74 @frankdejonge, please merge this, and tag! |
Contributor
|
👍 +1 — this currently blocks adopting webmozart/assert ^2.0 in downstream projects. Any chance of getting this merged or a 0.23 release cut? |
|
Anyone "alive" :-) on this repo ... please make an action and merge, it at least |
Member
Author
|
Released in version 0.24 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #264
Fixes #265