Respect modified dependency behaviors when disabling jobs#1134
Open
cottsay wants to merge 1 commit into
Open
Conversation
Member
Author
|
This is a bit tricky to test prior to deployment, but I did deploy it to build.test.ros2.org and observed the effects on the Fedora packages there, which use both of the flags plumbed through here. The net effect was that 30 packages got enabled which were previously unnecessarily disabled before this change, and no new packages got disabled. All 30 of the packages which got enabled built successfully. As confident as I might be, we should still wait until after Lyrical ships to merge this. |
cottsay
force-pushed
the
cottsay/disable-no-tests
branch
from
864a28d to
2f05978
Compare
This change plumbs the build file configuration values which augment dependency enumeration into the code which disables jobs downstream of other jobs which have been explicitly disabled in the build config.
cottsay
force-pushed
the
cottsay/disable-no-tests
branch
from
2f05978 to
fba1b6b
Compare
Member
Author
|
I updated this to include the status pages, but including groups support there will require more work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change plumbs the build file configuration values which augment dependency enumeration into the code which disables jobs downstream of other jobs which have been explicitly disabled in the build config.
Closes #1133