ext/standard: Fix proc_open() crash on macOS older than the build SDK#22607
Open
bukka wants to merge 1 commit into
Open
ext/standard: Fix proc_open() crash on macOS older than the build SDK#22607bukka wants to merge 1 commit into
bukka wants to merge 1 commit into
Conversation
posix_spawn_file_actions_addchdir() is only available since macOS 26, but the configure link check passes whenever the SDK exports the symbol, so building with the macOS 26 SDK for an older deployment target produces a weakly linked reference that resolves to NULL at runtime and proc_open() crashes when $cwd is used. Pick the variant at runtime via __builtin_available() when the deployment target is older than macOS 26.
Member
Author
Member
|
There's GH-21722; the approach there is a bit simpler after some reviewer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
posix_spawn_file_actions_addchdir() is only available since macOS 26, but the configure link check passes whenever the SDK exports the symbol, so building with the macOS 26 SDK for an older deployment target produces a weakly linked reference that resolves to NULL at runtime and proc_open() crashes when $cwd is used. Pick the variant at runtime via __builtin_available() when the deployment target is older than macOS 26.