Skip to content

chore: rename "Rust Dataflow Engine" to "OTel Arrow Dataflow Engine"#3416

Open
cijothomas wants to merge 2 commits into
open-telemetry:mainfrom
cijothomas:cijothomas/rename-otap-dataflow-engine
Open

chore: rename "Rust Dataflow Engine" to "OTel Arrow Dataflow Engine"#3416
cijothomas wants to merge 2 commits into
open-telemetry:mainfrom
cijothomas:cijothomas/rename-otap-dataflow-engine

Conversation

@cijothomas

@cijothomas cijothomas commented Jul 6, 2026

Copy link
Copy Markdown
Member

Aligns the src README, admin UI, dfctl TUI, and Cargo.toml description with the "OTel Arrow Dataflow Engine" naming.

Copilot AI review requested due to automatic review settings July 6, 2026 01:33
@cijothomas cijothomas requested a review from a team as a code owner July 6, 2026 01:33
@github-actions github-actions Bot added lang:rust Pull requests that update Rust code area:engine Internal engine features size/S labels Jul 6, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates user-facing naming across the Rust OTAP dataflow workspace to use “OTAP Dataflow Engine” instead of “Rust Dataflow Engine”, aligning docs/UI/package metadata with the terminology already used elsewhere in the repo.

Changes:

  • Renames the src/README.md heading to “OTAP Dataflow Engine”.
  • Updates the admin UI page/title to “OTAP Dataflow Engine”.
  • Updates workspace Cargo.toml package description to “OTAP Dataflow Engine …”.
  • Adjusts dfctl TUI title bar/test expectations (currently to “Dataflow Engine”, not “OTAP Dataflow Engine”).

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
rust/otap-dataflow/src/README.md Updates the local src README heading to “OTAP Dataflow Engine”.
rust/otap-dataflow/crates/ctl/src/ui/view/tests.rs Updates dfctl UI render test string for the title bar.
rust/otap-dataflow/crates/ctl/src/ui/view/chrome.rs Updates dfctl TUI title bar label (currently drops “Rust” but doesn’t add “OTAP”).
rust/otap-dataflow/crates/admin/ui/js/main.js Sets document.title to “OTAP Dataflow Engine”.
rust/otap-dataflow/crates/admin/ui/index.html Updates <title> and header text to “OTAP Dataflow Engine”.
rust/otap-dataflow/Cargo.toml Updates package description to “OTAP Dataflow Engine …”.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread rust/otap-dataflow/crates/ctl/src/ui/view/chrome.rs
Comment thread rust/otap-dataflow/crates/ctl/src/ui/view/tests.rs Outdated
@cijothomas cijothomas force-pushed the cijothomas/rename-otap-dataflow-engine branch from fc4f35c to a216b0f Compare July 6, 2026 01:45
@cijothomas cijothomas changed the title chore: rename "Rust Dataflow Engine" to "OTAP Dataflow Engine" chore: rename "Rust Dataflow Engine" to "OTel Arrow Dataflow Engine" Jul 6, 2026
@codecov

codecov Bot commented Jul 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.25%. Comparing base (474998a) to head (16d61dc).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3416      +/-   ##
==========================================
+ Coverage   86.23%   86.25%   +0.02%     
==========================================
  Files         739      741       +2     
  Lines      292355   292849     +494     
==========================================
+ Hits       252116   252603     +487     
- Misses      39715    39722       +7     
  Partials      524      524              
Components Coverage Δ
otap-dataflow 87.31% <100.00%> (+0.02%) ⬆️
query_engine 89.58% <ø> (ø)
otel-arrow-go 52.45% <ø> (ø)
quiver 92.19% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

let mut spans = brand_spans(app);
spans.extend([
Span::styled(" - Rust Dataflow Engine", title_style(app.color_enabled)),
Span::styled(" - Arrow Dataflow Engine", title_style(app.color_enabled)),

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it be "OTel Arrow Dataflow Engine too ?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh ignore, probably "OpenTelemetry" is already prefixed.

@jmacd jmacd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel that "OTel-Arrow" with a hyphen would be more appropriate, that way to avoid a stand-alone "OTel" abbreviation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:engine Internal engine features lang:rust Pull requests that update Rust code size/S

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

5 participants