chore: rename "Rust Dataflow Engine" to "OTel Arrow Dataflow Engine"#3416
chore: rename "Rust Dataflow Engine" to "OTel Arrow Dataflow Engine"#3416cijothomas wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates user-facing naming across the Rust OTAP dataflow workspace to use “OTAP Dataflow Engine” instead of “Rust Dataflow Engine”, aligning docs/UI/package metadata with the terminology already used elsewhere in the repo.
Changes:
- Renames the
src/README.mdheading to “OTAP Dataflow Engine”. - Updates the admin UI page/title to “OTAP Dataflow Engine”.
- Updates workspace
Cargo.tomlpackage description to “OTAP Dataflow Engine …”. - Adjusts dfctl TUI title bar/test expectations (currently to “Dataflow Engine”, not “OTAP Dataflow Engine”).
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| rust/otap-dataflow/src/README.md | Updates the local src README heading to “OTAP Dataflow Engine”. |
| rust/otap-dataflow/crates/ctl/src/ui/view/tests.rs | Updates dfctl UI render test string for the title bar. |
| rust/otap-dataflow/crates/ctl/src/ui/view/chrome.rs | Updates dfctl TUI title bar label (currently drops “Rust” but doesn’t add “OTAP”). |
| rust/otap-dataflow/crates/admin/ui/js/main.js | Sets document.title to “OTAP Dataflow Engine”. |
| rust/otap-dataflow/crates/admin/ui/index.html | Updates <title> and header text to “OTAP Dataflow Engine”. |
| rust/otap-dataflow/Cargo.toml | Updates package description to “OTAP Dataflow Engine …”. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fc4f35c to
a216b0f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3416 +/- ##
==========================================
+ Coverage 86.23% 86.25% +0.02%
==========================================
Files 739 741 +2
Lines 292355 292849 +494
==========================================
+ Hits 252116 252603 +487
- Misses 39715 39722 +7
Partials 524 524
🚀 New features to boost your workflow:
|
| let mut spans = brand_spans(app); | ||
| spans.extend([ | ||
| Span::styled(" - Rust Dataflow Engine", title_style(app.color_enabled)), | ||
| Span::styled(" - Arrow Dataflow Engine", title_style(app.color_enabled)), |
There was a problem hiding this comment.
should it be "OTel Arrow Dataflow Engine too ?
There was a problem hiding this comment.
Oh ignore, probably "OpenTelemetry" is already prefixed.
jmacd
left a comment
There was a problem hiding this comment.
I feel that "OTel-Arrow" with a hyphen would be more appropriate, that way to avoid a stand-alone "OTel" abbreviation.
Aligns the src README, admin UI, dfctl TUI, and Cargo.toml description with the "OTel Arrow Dataflow Engine" naming.