feat(core-nodes): emit df_engine.component.shutdown event from OTLP exporters#3349
Draft
cijothomas wants to merge 2 commits into
Draft
feat(core-nodes): emit df_engine.component.shutdown event from OTLP exporters#3349cijothomas wants to merge 2 commits into
cijothomas wants to merge 2 commits into
Conversation
…xporters Adds structured shutdown event with otel.component.type, otel.component.shutdown.result, and otel.component.shutdown.duration. Modeled after the OTel SDK otel.sdk.component.shutdown convention (open-telemetry/semantic-conventions#3723). - In-tree semconv event definition with attributes - Trigger script (99_ prefix ensures it runs last) - Emitted from both otlp_grpc_exporter and otlp_http_exporter
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3349 +/- ##
==========================================
- Coverage 86.20% 86.19% -0.01%
==========================================
Files 739 739
Lines 290493 290493
==========================================
- Hits 250420 250393 -27
- Misses 39549 39576 +27
Partials 524 524
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a structured shutdown event to the OTLP gRPC and HTTP exporters, modeled after the OTel SDK
otel.sdk.component.shutdownconvention (open-telemetry/semantic-conventions#3723).Changes
semconv/groups/event.component.shutdown.yaml) with full attribute declarations (otel.component.type,otel.component.shutdown.result,otel.component.shutdown.duration).otel_info!("otlp.exporter.grpc.shutdown")with timed structured event.99_df_engine.component.shutdown.sh) — POSTs to admin/api/v1/groups/shutdown?wait=trueso the event fires in CI before the hard-kill. Prefixed99_to ensure it runs last in the trigger glob.Notes
resultis alwayssuccesstoday (the drain loop runs to completion). A follow-up can check the deadline to detecttimed_out.durationis measured from message receipt, not from shutdown initiation (TODO in code — requires threadinginitiated_atthroughNodeControlMsg).df_engineprefix is provisional (product name unsettled; TODO in YAML).Related