Stop honoring deprecated telemetry.metrics.address#5231
Draft
ozzywalsh wants to merge 1 commit into
Draft
Conversation
The collector fully removed support for the address field; it now uses readers exclusively. The operator was still acting on address in MetricsEndpoint() and ServiceApplyDefaults(), causing the Kubernetes Service port to diverge from the actual collector metrics endpoint. Now address is ignored with a deprecation warning, and the operator always derives the metrics endpoint from readers or defaults. The upgrade system (v0_122_0) already migrates address to readers for existing CRs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
telemetry.metrics.addressfor the monitoring service; log a deprecation warning insteadaddress→readersautomatically, so this field should no longer be present in practiceaddressis set (since the collector ignores it)