Skip to content

fix(tests): pin Go e2e test app to 1.26.1 for eBPF offset compatibility#5180

Open
frzifus wants to merge 1 commit into
open-telemetry:mainfrom
frzifus:fix/pin-go-test-app-1.26.1
Open

fix(tests): pin Go e2e test app to 1.26.1 for eBPF offset compatibility#5180
frzifus wants to merge 1 commit into
open-telemetry:mainfrom
frzifus:fix/pin-go-test-app-1.26.1

Conversation

@frzifus

@frzifus frzifus commented Jun 3, 2026

Copy link
Copy Markdown
Member

Summary

  • Pins the Go e2e test app base image to golang:1.26.1-alpine instead of the floating 1.26-alpine tag
  • The Go auto-instrumentation (v0.24.0) only has cached eBPF offsets up to Go 1.26.1. The recent Go 1.26 upgrade (chore: update Go to 1.26 #5173) resolved to Go 1.26.3 via the floating tag, causing instrumentation-go e2e tests to fail with no telemetry data produced
  • Once a new opentelemetry-go-instrumentation release adds offsets for Go 1.26.3+, this pin can be removed

See: https://github.com/open-telemetry/opentelemetry-go-instrumentation/releases/

Test plan

  • e2e-instrumentation CI job passes (specifically instrumentation-go test)

@frzifus frzifus requested a review from a team as a code owner June 3, 2026 00:29
@frzifus frzifus requested review from iblancasa and yuriolisa June 3, 2026 00:29
@frzifus frzifus added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jun 3, 2026
@frzifus frzifus enabled auto-merge (squash) June 3, 2026 00:30
@frzifus frzifus force-pushed the fix/pin-go-test-app-1.26.1 branch from 7614902 to 195fc26 Compare June 3, 2026 00:33
The Go auto-instrumentation (v0.24.0) only has cached eBPF offsets up
to Go 1.26.1. The recent Go 1.26 upgrade (open-telemetry#5173) pulled in Go 1.26.3
via the floating tag, causing the instrumentation-go e2e test to fail
because no matching offsets exist for 1.26.3.

Signed-off-by: Benedikt Bongartz <bongartz@klimlive.de>
@frzifus frzifus force-pushed the fix/pin-go-test-app-1.26.1 branch from 195fc26 to 97ee357 Compare June 3, 2026 00:46
@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

E2E Test Results

 37 files  214 suites   2h 6m 35s ⏱️
101 tests  98 ✅ 1 💤 2 ❌
235 runs  229 ✅ 2 💤 4 ❌

Results for commit 2aa74a5.

♻️ This comment has been updated with latest results.

@frzifus frzifus force-pushed the fix/pin-go-test-app-1.26.1 branch from 97ee357 to 2aa74a5 Compare June 3, 2026 01:20
@swiatekm

swiatekm commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Doesn't look like this is fixing the failures. Maybe we should revert the Go test app change until we figure this out?

@iblancasa

Copy link
Copy Markdown
Member

Doesn't look like this is fixing the failures. Maybe we should revert the Go test app change until we figure this out?

I think we should deprecate Go instrumentation #4539

@swiatekm

swiatekm commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Doesn't look like this is fixing the failures. Maybe we should revert the Go test app change until we figure this out?

I think we should deprecate Go instrumentation #4539

That, too, but first we need to unblock our CI in the simplest possible change.

@frzifus

frzifus commented Jun 3, 2026

Copy link
Copy Markdown
Member Author

Doesn't look like this is fixing the failures. Maybe we should revert the Go test app change until we figure this out?

I think we should deprecate Go instrumentation #4539

That, too, but first we need to unblock our CI in the simplest possible change.

@iblancasa @swiatekm In any case I think we have to force merge something. 😓

@swiatekm

swiatekm commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Doesn't look like this is fixing the failures. Maybe we should revert the Go test app change until we figure this out?

I think we should deprecate Go instrumentation #4539

That, too, but first we need to unblock our CI in the simplest possible change.

@iblancasa @swiatekm In any case I think we have to force merge something. 😓

I don't think we do? The Go 1.26.4 update PR passes govulncheck. We just need to disable the Go e2e test there. Let me have a stab at it.

@swiatekm

swiatekm commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

@frzifus can you build this locally and sure it passes e2e tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants