fix(tests): pin Go e2e test app to 1.26.1 for eBPF offset compatibility#5180
fix(tests): pin Go e2e test app to 1.26.1 for eBPF offset compatibility#5180frzifus wants to merge 1 commit into
Conversation
7614902 to
195fc26
Compare
The Go auto-instrumentation (v0.24.0) only has cached eBPF offsets up to Go 1.26.1. The recent Go 1.26 upgrade (open-telemetry#5173) pulled in Go 1.26.3 via the floating tag, causing the instrumentation-go e2e test to fail because no matching offsets exist for 1.26.3. Signed-off-by: Benedikt Bongartz <bongartz@klimlive.de>
195fc26 to
97ee357
Compare
E2E Test Results 37 files 214 suites 2h 6m 35s ⏱️ Results for commit 2aa74a5. ♻️ This comment has been updated with latest results. |
97ee357 to
2aa74a5
Compare
|
Doesn't look like this is fixing the failures. Maybe we should revert the Go test app change until we figure this out? |
I think we should deprecate Go instrumentation #4539 |
That, too, but first we need to unblock our CI in the simplest possible change. |
@iblancasa @swiatekm In any case I think we have to force merge something. 😓 |
I don't think we do? The Go 1.26.4 update PR passes govulncheck. We just need to disable the Go e2e test there. Let me have a stab at it. |
|
@frzifus can you build this locally and sure it passes e2e tests? |
Summary
golang:1.26.1-alpineinstead of the floating1.26-alpinetagv0.24.0) only has cached eBPF offsets up to Go 1.26.1. The recent Go 1.26 upgrade (chore: update Go to 1.26 #5173) resolved to Go 1.26.3 via the floating tag, causinginstrumentation-goe2e tests to fail with no telemetry data producedopentelemetry-go-instrumentationrelease adds offsets for Go 1.26.3+, this pin can be removedSee: https://github.com/open-telemetry/opentelemetry-go-instrumentation/releases/
Test plan
e2e-instrumentationCI job passes (specificallyinstrumentation-gotest)