[receiver/datadog] Reconstruct 128-bit trace IDs for spans regardless of order#49496
Open
SpencerTorres wants to merge 3 commits into
Open
[receiver/datadog] Reconstruct 128-bit trace IDs for spans regardless of order#49496SpencerTorres wants to merge 3 commits into
SpencerTorres wants to merge 3 commits into
Conversation
… of order within a payload
SpencerTorres
force-pushed
the
datadog-traces-128bit-ordering
branch
from
58507d2 to
ba64d79
Compare
…y-collector-contrib into datadog-traces-128bit-ordering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR improves consistency in the trace IDs by iterating the payload so every span resolves to the same 128-bit ID
regardless of order. Depends on the existing
receiver.datadogreceiver.Enable128BitTraceIDfeature gate which is enabled by default.If this loop becomes a performance issue we can re-evaluate it in the future
Testing
Added unit tests
Authorship