[receiver/splunk_hec] Fix read_header_timeout and write_timeout configuration options getting overridden#49483
Open
dyl10s wants to merge 2 commits into
Open
[receiver/splunk_hec] Fix read_header_timeout and write_timeout configuration options getting overridden#49483dyl10s wants to merge 2 commits into
read_header_timeout and write_timeout configuration options getting overridden#49483dyl10s wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There were some hard coded timeout values for
read_header_timeoutandwrite_timeoutset in the receiver startup. Even though the config options were exposed they would get overridden.This PR moves the defaults into
createDefaultConfigso a users configuration options will overrride them.Testing
Test written to test that the config options apply to the server
Authorship