[receiver/postgresql] Update explainQuery client method to also include context#49472
Draft
kartikgola wants to merge 7 commits into
Draft
[receiver/postgresql] Update explainQuery client method to also include context#49472kartikgola wants to merge 7 commits into
explainQuery client method to also include context#49472kartikgola wants to merge 7 commits into
Conversation
Contributor
|
Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib. Important reminders:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Noticed this issue (while working on #49352) where
explainQueryAPI in client.go doesn't take in context unlike the rest of the interface functions, and uses background context instead.This can be problematic since if the context is cancelled, the
explainQueryAPI will not honor it and could keep on going. Some problems that can arise -As part of the fix, I added the
contextback in the API and updated the function.There's a small caveat with
DEALLOCATE PREPAREthough; In the original code it was using global context and was unbounded, I have now added it with a timed out context sinceDEALLOCATE PREPAREmust be called even if the parent context is cancelled to stop polluting the shared connection pool.Testing
Unit tests
Documentation
N/A
Authorship