Skip to content

[chore][connector/servicegraphconnector] Updating semconv version #49469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
anarwal wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −5
Draft

[chore][connector/servicegraphconnector] Updating semconv version #49469

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions connector/servicegraphconnector/connector.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,7 @@
"go.opentelemetry.io/collector/pdata/pmetric"
"go.opentelemetry.io/collector/pdata/ptrace"
"go.opentelemetry.io/collector/processor"
conventionsv125 "go.opentelemetry.io/otel/semconv/v1.25.0"
conventionsv128 "go.opentelemetry.io/otel/semconv/v1.28.0"
conventionsv138 "go.opentelemetry.io/otel/semconv/v1.38.0"
conventions "go.opentelemetry.io/otel/semconv/v1.40.0"
"go.uber.org/zap"

"github.com/open-telemetry/opentelemetry-collector-contrib/connector/servicegraphconnector/internal/metadata"
Expand All @@ -48,10 +46,10 @@
}

defaultPeerAttributes = []string{
string(conventionsv138.PeerServiceKey), string(conventionsv125.DBNameKey), string(conventionsv128.DBSystemKey),
string(conventions.PeerServiceKey), "db.name", "db.system",

Check failure on line 49 in connector/servicegraphconnector/connector.go

View workflow job for this annotation

GitHub Actions / govulncheck (connector) 

undefined: conventions.PeerServiceKey
}

defaultDatabaseNameAttributes = []string{string(conventionsv125.DBNameKey)}
defaultDatabaseNameAttributes = []string{"db.name"}

defaultMetricsFlushInterval = 60 * time.Second // 1 DPM
)
Expand Down
Loading