Skip to content

[chore][pkg/translator/jaeger] Update semconv version #49468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
anarwal wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −2
Draft

[chore][pkg/translator/jaeger] Update semconv version #49468

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions pkg/translator/jaeger/jaegerproto_to_traces.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ import (
"github.com/jaegertracing/jaeger-idl/model/v1"
"go.opentelemetry.io/collector/pdata/pcommon"
"go.opentelemetry.io/collector/pdata/ptrace"
conventionsv125 "go.opentelemetry.io/otel/semconv/v1.25.0"
conventions "go.opentelemetry.io/otel/semconv/v1.40.0"

"github.com/open-telemetry/opentelemetry-collector-contrib/internal/coreinternal/occonventions"
Expand Down Expand Up @@ -288,7 +287,7 @@ func setInternalSpanStatus(attrs pcommon.Map, span ptrace.Span) {
// otel.status_message tag will have already been removed if
// statusExists is true.
attrs.Remove(string(conventions.OTelStatusCodeKey))
} else if httpCodeAttr, ok := attrs.Get(string(conventionsv125.HTTPStatusCodeKey)); !statusExists && ok {
} else if httpCodeAttr, ok := attrs.Get("http.status_code"); !statusExists && ok {
// Fallback to introspecting if this span represents a failed HTTP
// request or response, but again, only do so if the `error` tag was
// not set to true and no explicit status was sent.
Expand Down
Loading