Use stable network attributes#49465
Open
avy252004 wants to merge 3 commits into
Open
Conversation
…rk attribute using feature gate
Contributor
|
Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib. Important reminders:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the "use of stable network attributes from deprecated ones" for the
tcp_inputandudp_inputoperators to reflect the migration from deprecatednet.*attributes to the stablenetwork.*semantic conventions.When the
StanzaUseStableNetworkAttributesFeatureGateconfiguration is enabled, users can now opt-in to the stable attributes via a new feature flag.When the feature flag is enabled, the following attributes are replaced:
net.transportnetwork.transport("tcp" / "udp")net.peer.ipnetwork.peer.addressnet.peer.portnetwork.peer.portnet.host.ipnetwork.local.addressnet.host.portnetwork.local.portPlease note that
net.peer.nameandnet.host.nameare being dropped and do not have stable replacements under the new feature flag.client.addressandserver.address) are HTTP-flavored and require making assumptions about which side of the socket is the "client" versus the "server". Such assumptions we cannot safely make for TCP/UDP inputs.stanza.useStableNetworkAttributesfeature flag is enabled, these two attributes will no longer be emitted. Users relying on these attributes for reverse-DNS hostname resolution will need to account for their absence in downstream processing.Link to tracking issue
Fixes #49051
Testing
setStableNetworkAttributesGatefunction added to bothtcp/udp_test.gofiles.Documentation
pkg/stanza/documentation.mdchanged and added theAdded details for
stanza.useStableNetworkAttributesin the relevant operator READMEs / feature flag registry.Authorship