Validate the inputStream argument in KeyVal.inputStream#2525
Open
vasiliy-mikhailov wants to merge 1 commit into
Open
Validate the inputStream argument in KeyVal.inputStream#2525vasiliy-mikhailov wants to merge 1 commit into
vasiliy-mikhailov wants to merge 1 commit into
Conversation
KeyVal.inputStream(InputStream) validated the value field instead of the inputStream argument, so inputStream(null) was not rejected (and a KeyVal with a null value would fail with a misleading message). Validate the argument that is actually used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HttpConnection.KeyVal.inputStream(InputStream)callsValidate.notNullParam(value, "inputStream")— it validates the unrelatedvaluefield instead of theinputStreamargument. SoinputStream(null)is silently accepted (a null stream is stored), while aKeyValwhosevalueis null would fail with a misleading "The parameter 'inputStream' must not be null."Validate the argument that's actually used. Extended the existing
inputStream()test.Verifying this change
The added
HttpConnectionTest#inputStreamcase fails before this change and passes after:Before the fix:
After the fix:
AI assistance disclosure
This contribution was produced with the help of an AI pipeline. The pipeline processed a large amount of source code to surface suspected bugs, reproduced a subset of them with failing unit tests and generated candidate fixes, and prepared pull requests from the ones that held up. Each PR was then reviewed and verified by a human before being opened: the fix and test were checked by hand and the test was confirmed to fail before the change and pass after.