fix(queue): read running under mutex in loop to avoid data race#909
Open
Noethix55555 wants to merge 1 commit into
Open
fix(queue): read running under mutex in loop to avoid data race#909Noethix55555 wants to merge 1 commit into
Noethix55555 wants to merge 1 commit into
Conversation
loop() read q.running without holding q.mut while Stop() and Run() wrote it under the mutex, a data race detected by go test -race. Snapshot running under q.mut at the top of each loop iteration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@
Fixes #907
Problem
Queue.loop()read therunningfield without holdingq.mut, whileStop()andRun()write it underq.mut. This is a data race, reported bygo test -race:Fix
Snapshot
runningunderq.mutat the top of each loop iteration and use the local copy for the termination check.Test
Added
TestQueueStopRace: queues several thousand requests, then callsStop()from another goroutine whileRun()is processing. Run with-raceit fails on master and passes with this change. The fullgo test -race ./queue/...suite passes.@