fix(robots): preserve query string order in robots.txt matching#903
Open
Noethix55555 wants to merge 1 commit into
Open
fix(robots): preserve query string order in robots.txt matching#903Noethix55555 wants to merge 1 commit into
Noethix55555 wants to merge 1 commit into
Conversation
robots.txt path matching treats the path and query as an ordered, opaque string. checkRobots re-encoded the query with u.Query().Encode(), which alphabetically sorts the keys, so a Disallow rule containing a query string (e.g. /p?z=) failed to match a URL with the same keys in a different order. Use u.RawQuery verbatim instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #902
robots.txt path matching treats the path and query as an ordered, opaque string.
checkRobotsre-encoded the query withu.Query().Encode(), which alphabetically sorts the keys. As a result aDisallowrule containing a query string (e.g./p?z=) failed to match a URL with the same keys in a different on-wire order, silently bypassing the rule.This uses
u.RawQueryverbatim. Added a regression test servingDisallow: /p?z=and asserting that/p?z=1&a=2is blocked; it fails on master (request is served with 200) and passes with the fix.