fix(domain): strip trailing dot before domain filtering#901
Open
Noethix55555 wants to merge 1 commit into
Open
fix(domain): strip trailing dot before domain filtering#901Noethix55555 wants to merge 1 commit into
Noethix55555 wants to merge 1 commit into
Conversation
A trailing-dot FQDN such as "example.com." refers to the same host as "example.com" but was not string-equal to a configured domain. This let it bypass DisallowedDomains and be wrongly blocked by AllowedDomains. Trim the trailing dot in isDomainAllowed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #900
A trailing-dot FQDN such as
example.com.refers to the same host asexample.combut was not string-equal to a configured domain. As a result it bypassedDisallowedDomainsand was wrongly blocked byAllowedDomains.This trims the trailing dot at the top of
isDomainAllowed. Added a table-driven regression test asserting thatDisallowedDomains("example.com")blocks bothexample.comandexample.com., and thatAllowedDomains("example.com")allowsexample.com.. It fails on master and passes with the fix.