fix(context): avoid Context.Clone deadlock under a concurrent writer#884
Open
Shinku-Chen wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context.Clone held c.lock.RLock and then called c.ForEach, which
acquires c.lock.RLock a second time on the same goroutine. sync.RWMutex
intentionally starves additional readers once a writer is queued (to
prevent writer starvation), so the second RLock could block forever,
deadlocking Clone whenever any other goroutine had a Put queued
between the two RLock calls.
Iterate c.contextMap directly under the single RLock instead, copying
each entry into the freshly constructed (uncontended) new context. No
behavior change for callers; the lock acquisition count drops from
two to one.
Add TestContextCloneConcurrentWriter, which fires 500 Clone calls and
500 Put calls in parallel under a 5s deadline. The test reliably
times out on the previous implementation and completes in tens of
milliseconds with the fix.