Skip to content

fix(github): make pullRequestComment commentTag templateable#452

Open
singeol wants to merge 1 commit into
argoproj:masterfrom
singeol:fix/templateable-github-comment-tag
Open

fix(github): make pullRequestComment commentTag templateable#452
singeol wants to merge 1 commit into
argoproj:masterfrom
singeol:fix/templateable-github-comment-tag

Conversation

@singeol

@singeol singeol commented Jun 2, 2026

Copy link
Copy Markdown

docs/services/github.md already shows templated pullRequestComment.commentTag, but the implementation currently treats commentTag as a literal string.

This causes multiple Argo CD Applications associated with the same PR to overwrite one another's comments instead of upserting independently.

This change renders pullRequestComment.commentTag through the Go templating engine, adds test coverage, and updates the GitHub service docs.

This is a partial fix for #355 and addresses the templateable commentTag portion of #433.

Signed-off-by: Semyon Mikhailov <mikhailovsv@evrone.team>
@singeol singeol force-pushed the fix/templateable-github-comment-tag branch from e2951e6 to 7b82865 Compare June 2, 2026 16:32
@codecov

codecov Bot commented Jun 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 76.47059% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.16%. Comparing base (da04400) to head (7b82865).
⚠️ Report is 37 commits behind head on master.

Files with missing lines Patch % Lines
pkg/services/github.go 76.47% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #452      +/-   ##
==========================================
+ Coverage   55.41%   57.16%   +1.75%     
==========================================
  Files          46       49       +3     
  Lines        4125     3794     -331     
==========================================
- Hits         2286     2169     -117     
+ Misses       1511     1265     -246     
- Partials      328      360      +32     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant