fix(subscriptions): preserve recipient separators on unsubscribe#450
Open
immanuwell wants to merge 1 commit into
Open
fix(subscriptions): preserve recipient separators on unsubscribe#450immanuwell wants to merge 1 commit into
immanuwell wants to merge 1 commit into
Conversation
Signed-off-by: immanuwell <pchpr.00@list.ru>
262c13c to
352e687
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #450 +/- ##
==========================================
+ Coverage 55.41% 57.35% +1.93%
==========================================
Files 46 49 +3
Lines 4125 3782 -343
==========================================
- Hits 2286 2169 -117
+ Misses 1511 1254 -257
- Partials 328 359 +31 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small bug in
Annotations.Unsubscribe().If an annotation has a few recipients, unsubscribing one of them rebuilds the value with no
;. Somy-channel1;my-channel2;my-channel3turns intomy-channel1my-channel3. Kinda busted, and the remaining subscription stops matching real recipients.This patch keeps the
;separator and adds a regression test.Repro
notifications.argoproj.io/subscribe.my-trigger.slack: my-channel1;my-channel2;my-channel3Unsubscribe("my-trigger", "slack", "my-channel2")masteryou getmy-channel1my-channel3my-channel1;my-channel3