fix(ui): sync cron workflow list filters to URL query params#16386
fix(ui): sync cron workflow list filters to URL query params#16386amarkdotdev wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughCron workflow list now initializes label and state filters from URL query parameters and rewrites the history query string from the current filter state, including repeated label/state params and an optional sidePanel flag. ChangesURL-synced filter state
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related issues
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ui/src/cron-workflows/cron-workflow-list.tsx`:
- Around line 64-77: The cron workflow list builds multi-value filter params
with repeated label/state keys, but the shared URL merge logic is collapsing
them to a single value. Update the `historyUrl` handling in
`ui/src/shared/history.ts` so `extraSearchParams` preserves repeated keys by
using append semantics instead of set semantics, keeping multi-select filters
intact for callers like `cron-workflow-list.tsx`.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 685b0d61-1fa0-4f43-ab6a-75882b8482e3
📒 Files selected for processing (1)
ui/src/cron-workflows/cron-workflow-list.tsx
Persist label and state filters in the URL so CronWorkflow list views can be shared and restored on refresh, matching workflow-template-list behavior. Fixes argoproj#13168 Signed-off-by: amarkdotdev <amarkdotdev@users.noreply.github.com>
66f2d84 to
27af34d
Compare
Summary
Fixes #13168
Test plan
Summary by CodeRabbit