fix: use active login for existing sessions#2682
Conversation
|
Thanks for opening this pull request and contributing to the project! The next step is for the maintainers to review your changes. If everything looks good, it will be approved and merged into the main branch. In the meantime, anyone in the community is encouraged to test this pull request and provide feedback. ✅ How to confirm it worksIf you’ve tested this PR, please comment below with: This helps us speed up the review and merge process. 📦 To test this PR locally:If you encounter any issues or have feedback, feel free to comment as well. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe ChangesLogin Payload Flag Update
Estimated code review effort: 1 (Trivial) | ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install failed. For unrecoverable errors, disable the tool in CodeRabbit configuration. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
generateLoginNodeto sendpassive: falseWhy
Real reconnect/import testing has shown WhatsApp can terminate login-node flows with 428 when the existing companion session is sent as passive. Registration already uses
passive: false; login should use the same active mode for an existing session.Checks
git diff --checkI could not run the full project build in this clean worktree because dependencies are not installed and
yarnis not available on the host.Summary by cubic
Use active login for existing companion sessions by setting passive: false in the login payload. Prevents 428 rejections during reconnect/import and aligns login with registration behavior.
Written for commit 680f61a. Summary will update on new commits.
Summary by CodeRabbit