fix: support nested query param schemas [INS-2424]#10219
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the OpenAPI 3 importer so nested object-shaped query parameter schemas are represented as flattened parameters (instead of rendering as "[object Object]"), and adds unit tests covering nested query parameter cases.
Changes:
- Add
flattenParameter()and switch query parameter conversion to flatten object-shaped examples into bracket notation names. - Add Vitest coverage to ensure nested query parameter schemas produce flattened parameter entries and never output
"[object Object]".
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/insomnia/src/main/importers/importers/openapi-3.ts | Flattens object-shaped parameter examples into multiple params instead of stringifying objects. |
| packages/insomnia/src/main/importers/importers/openapi-3.test.ts | Adds tests validating nested query param flattening output and preventing "[object Object]". |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
✅ Circular References ReportGenerated at: 2026-07-07T21:27:01.100Z Summary
Click to view all circular references in PR (9)Click to view all circular references in base branch (9)Analysis✅ No Change: This PR does not introduce or remove any circular references. This report was generated automatically by comparing against the |
fiosman
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now shows flattened query params with defaults/examples instead of
[object Object]: