Skip to content

fix: support nested query param schemas [INS-2424]#10219

Merged
ryan-willis merged 1 commit into
developfrom
fix/flatten-nested-oas-params-INS-2424
Jul 7, 2026
Merged

fix: support nested query param schemas [INS-2424]#10219
ryan-willis merged 1 commit into
developfrom
fix/flatten-nested-oas-params-INS-2424

Conversation

@ryan-willis

Copy link
Copy Markdown
Contributor

Now shows flattened query params with defaults/examples instead of [object Object]:

Screenshot 2026-07-07 at 14 20 38

Copilot AI review requested due to automatic review settings July 7, 2026 21:21

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the OpenAPI 3 importer so nested object-shaped query parameter schemas are represented as flattened parameters (instead of rendering as "[object Object]"), and adds unit tests covering nested query parameter cases.

Changes:

  • Add flattenParameter() and switch query parameter conversion to flatten object-shaped examples into bracket notation names.
  • Add Vitest coverage to ensure nested query parameter schemas produce flattened parameter entries and never output "[object Object]".

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
packages/insomnia/src/main/importers/importers/openapi-3.ts Flattens object-shaped parameter examples into multiple params instead of stringifying objects.
packages/insomnia/src/main/importers/importers/openapi-3.test.ts Adds tests validating nested query param flattening output and preventing "[object Object]".

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/insomnia/src/main/importers/importers/openapi-3.ts
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

✅ Circular References Report

Generated at: 2026-07-07T21:27:01.100Z
Status: ✅ NO CHANGE

Summary

Metric Base (develop) PR Change
Total Circular References 9 9 0 (0.00%)
Click to view all circular references in PR (9)
insomnia-inso/src/db/models/types.ts -> insomnia-inso/src/db/types.ts
insomnia/src/main/prompt-bridge.ts -> insomnia/src/main/window-utils.ts -> insomnia/src/main/plugin-window.ts
insomnia/src/main/window-utils.ts -> insomnia/src/main/plugin-window.ts
insomnia/src/network/network.ts -> insomnia-scripting-environment/src/objects/index.ts -> insomnia-scripting-environment/src/objects/collection.ts -> insomnia-scripting-environment/src/objects/response.ts
insomnia/src/network/network.ts -> insomnia/src/common/render.ts
insomnia/src/ui/components/settings/import-export.tsx -> insomnia/src/ui/components/modals/export-requests-modal.tsx
insomnia/src/ui/components/tabs/tab-list.tsx -> insomnia/src/ui/components/tabs/tab.tsx
insomnia/src/ui/components/templating/tag-editor-arg-sub-form.tsx -> insomnia/src/ui/components/templating/external-vault/external-vault-form.tsx
insomnia/src/ui/components/viewers/response-viewer.tsx -> insomnia/src/ui/components/viewers/response-multipart-viewer.tsx
Click to view all circular references in base branch (9)
insomnia-inso/src/db/models/types.ts -> insomnia-inso/src/db/types.ts
insomnia/src/main/prompt-bridge.ts -> insomnia/src/main/window-utils.ts -> insomnia/src/main/plugin-window.ts
insomnia/src/main/window-utils.ts -> insomnia/src/main/plugin-window.ts
insomnia/src/network/network.ts -> insomnia-scripting-environment/src/objects/index.ts -> insomnia-scripting-environment/src/objects/collection.ts -> insomnia-scripting-environment/src/objects/response.ts
insomnia/src/network/network.ts -> insomnia/src/common/render.ts
insomnia/src/ui/components/settings/import-export.tsx -> insomnia/src/ui/components/modals/export-requests-modal.tsx
insomnia/src/ui/components/tabs/tab-list.tsx -> insomnia/src/ui/components/tabs/tab.tsx
insomnia/src/ui/components/templating/tag-editor-arg-sub-form.tsx -> insomnia/src/ui/components/templating/external-vault/external-vault-form.tsx
insomnia/src/ui/components/viewers/response-viewer.tsx -> insomnia/src/ui/components/viewers/response-multipart-viewer.tsx

Analysis

No Change: This PR does not introduce or remove any circular references.


This report was generated automatically by comparing against the develop branch.

@ryan-willis ryan-willis enabled auto-merge (squash) July 7, 2026 21:30
@ryan-willis ryan-willis merged commit 99a55ac into develop Jul 7, 2026
34 of 36 checks passed
@ryan-willis ryan-willis deleted the fix/flatten-nested-oas-params-INS-2424 branch July 7, 2026 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants