Fix TestClient IPv6 base_url parsing#3368
Open
krrishapatel wants to merge 1 commit into
Open
Conversation
The netloc split on `:` failed for IPv6 addresses like `[::1]:8000`, raising `ValueError: invalid literal for int()`. Now detects bracket notation and extracts the bare IPv6 address and port correctly.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #3357 (same class of bug —
:splitting breaks IPv6).TestClientwith an IPv6base_urllikehttp://[::1]:8000crashes withValueError: invalid literal for int() with base 10: ':1]'because the netloc is split on:without accounting for bracket notation.This adds IPv6-aware parsing that extracts the bare address and port from bracketed notation before falling through to the existing split logic.
Assisted-by: Claude Opus 4.6