Optional Cache-Control header support to Staticfile responses#3248
Open
diskeu wants to merge 2 commits into
Open
Optional Cache-Control header support to Staticfile responses#3248diskeu wants to merge 2 commits into
diskeu wants to merge 2 commits into
Conversation
diskeu
force-pushed
the
add/static_file-cache-control
branch
from
a111d83 to
b5780e4
Compare
This adds an optional `cache_control` parameter to `Staticfiles` and allows developers to set a default `Cache-Control` for all served static files. No changes to the default behavior if `cache_control` is not set.
diskeu
force-pushed
the
add/static_file-cache-control
branch
from
b5780e4 to
0f56eb6
Compare
diskeu
force-pushed
the
add/static_file-cache-control
branch
from
0f56eb6 to
c35c871
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds an optional
cache_controlparameter toStaticFiles, allowing developers to set a defaultCache-Controlheader for all static file responses.This does not change the default behavior when the parameter is not provided.
Why this makes sense
Providing a simple way to configure a default
Cache-Controlheader for static files simplifies commondeployment scenarios.
Many small services rely on a basic cache policy for static assets. This change allows that behavior
to be configured directly without requiring additional middleware or custom wrappers.
Checklist