Improve typing for add_exception_handler#3219
Open
Ragug wants to merge 8 commits into
Open
Conversation
Allow handlers to accept specific Exception subclasses using overloads. This improves type inference without changing runtime behavior.
- Use @overload to differentiate between Exception types and status code integers. - Synchronize parameter names to fix mypy [misc] implementation errors. - Broaden implementation handler signature to support generic Exception types.
Author
|
Hi @Kludex, I’d appreciate it if you could review this and let me know if any changes are needed. Looking forward to your feedback. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This improves type inference for
add_exception_handlerby allowing handlersto accept specific
Exceptionsubclasses instead of onlyException.For example, the following now type-checks correctly:
This is achieved using overloads while preserving the existing runtime behavior.
No runtime changes are introduced.
Note: This PR intentionally does not attempt to improve typing for the
exception_handlersmapping, as its key-dependent typing cannot be fullyexpressed in Python's type system.
Related discussion: #2403
Checklist