Skip to content

Diaz perez#514

Open
jverzani wants to merge 2 commits into
JuliaMath:masterfrom
jverzani:diaz-perez
Open

Diaz perez#514
jverzani wants to merge 2 commits into
JuliaMath:masterfrom
jverzani:diaz-perez

Conversation

@jverzani

@jverzani jverzani commented Jul 8, 2026

Copy link
Copy Markdown
Member

Give regula falsi methods some attention:

  • uses dispatch for FalsePosition
  • adds some names to FalsePosition
  • make FalsePosition a type of AbstractRegulaFalsiMethod so that bracket is recorded when traced
  • adds new RegulaFalsi methods based on Diaz-Perez parameterization. For those that match FalsePosition's methods, these utiliize the same or fewer function calls
  • fixed bug with decide_convergence when brackting method failed to converge; this forced tests to be adjusted

@codecov

codecov Bot commented Jul 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 88.05970% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.82%. Comparing base (31ca988) to head (57ee77f).

Files with missing lines Patch % Lines
src/Bracketing/false_position.jl 73.68% 5 Missing ⚠️
src/Bracketing/regula_falsi.jl 93.61% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #514      +/-   ##
==========================================
- Coverage   86.94%   86.82%   -0.13%     
==========================================
  Files          41       42       +1     
  Lines        2567     2604      +37     
==========================================
+ Hits         2232     2261      +29     
- Misses        335      343       +8     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant