Skip to content

Spelling#2242

Open
jsoref wants to merge 132 commits into
Azure:devfrom
jsoref:spelling
Open

Spelling#2242
jsoref wants to merge 132 commits into
Azure:devfrom
jsoref:spelling

Conversation

@jsoref

@jsoref jsoref commented Jan 4, 2026

Copy link
Copy Markdown
Contributor

Summary of the changes (Less than 80 chars)

  • Fix typos
  • Fix grammar
  • Make links accessible

jsoref
jsoref commented Jan 4, 2026
View reviewed changes
Comment thread .github/ISSUE_TEMPLATE/bug_report.md
Comment thread .github/ISSUE_TEMPLATE/bug_report.md
Comment thread docs/advanced-topics/json-object-serializer.md
Comment thread docs/swagger/v1-preview.json
Comment thread docs/swagger/V20220601.json
Comment thread docs/howto-tsg.md
Comment thread src/Microsoft.Azure.SignalR.Emulator/Common/HttpContextExtensions.cs
Comment thread test/Microsoft.Azure.SignalR.Common.Tests/BackOffPolicyFacts.cs
Comment thread test/Microsoft.Azure.SignalR.Protocols.Tests/ServiceProtocolFacts.cs
@jsoref

jsoref commented Jan 4, 2026

Copy link
Copy Markdown
Contributor Author

The fixes I'm including more or less resolve the items identified in https://github.com/jsoref/azure-signalr/actions/runs/20695061439/attempts/1#summary-59408907164

vicancy
vicancy reviewed Jan 27, 2026
View reviewed changes

@vicancy vicancy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Just some little comments.

Comment thread src/Microsoft.Azure.SignalR.Common/ServiceConnections/MultiEndpointMessageWriter.cs Outdated
Comment thread ...Microsoft.Azure.SignalR.Common/ServiceConnections/MultiEndpointServiceConnectionContainer.cs Outdated
@jsoref

jsoref commented Jan 27, 2026

Copy link
Copy Markdown
Contributor Author

This should address the review comments. I'll rebase to deal w/ the merge conflict

jsoref added 24 commits January 27, 2026 07:37
@jsoref
link: Advanced HTTP configuration options
1e4fb9a 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
link: Azure SignalR Service documentation
9fa6408 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
link: Azure SignalR Service FAQ (learn.microsoft.com)
88d8aae 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
link: Azure SignalR Service internals (learn.microsoft.com)
3c6a40c 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
link: Azure SignalR Service data plane REST API - v1-preview (learn.m…
b0423b9 
…icrosoft.com)

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
link: Azure SignalR Service data plane REST API - v1(learn.microsoft.…
51c1093 
…com)

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
link: Azure SignalR Service data-plane REST API reference (learn.micr…
d434325 
…osoft.com)

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
link: chat room sample
f95dec1 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
link: Client negotiation (learn.microsoft.com)
2dcb079 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
link: For ASP.NET Core SignalR (learn.microsoft.com)
ad4953f 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
link: For the legacy ASP.NET SignalR (learn.microsoft.com)
99dd859 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
link: How to troubleshoot connectivity and message delivery issues (l…
35481d0 
…earn.microsoft.com)

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
link: Management SDK sample
c1e7bee 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
link: Performance guide for Azure SignalR Service (learn.microsoft.com)
03c9925 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
link: samples on how to use Azure SignalR Service
1e6260c 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
link: Scale SignalR Service with multiple instances (learn.microsoft.…
22b3f2e 
…com)

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
link: Transport Type
0b751de 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
link: Troubleshooting guide for Azure SignalR Service common issues (…
ac59c54 
…learn.microsoft.com)

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
link: Use Azure SignalR Local Emulator for serverless development (le…
e76cba0 
…arn.microsoft.com)

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
link: Use Azure SignalR Management SDK (learn.microsoft.com)
1277949 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
link: Use Azure SignalR Service (learn.microsoft.com)
426c2bb 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
link: Use resource logs to monitor SignalR Service (learn.microsoft.com)
3c6bb04 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: ; otherwise,
974c2e1 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: a
630c135 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
jsoref added 29 commits January 27, 2026 07:37
@jsoref
spelling: prerequisites
b0f6d5d 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: pressure
bff769f 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: protocol
86b6d13 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: realizes
100315e 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: receive
3f524e3 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: result
8a0510a 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: returns
d646783 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: secondary
48ed95d 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: security
c1d4987 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: separators
8eb3b84 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: serializer
845088e 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: service
78c3f7a 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: should
bf31eba 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: simple
7518d8d 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: some
a8e73c0 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: specified
9582f97 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: sticky
34eddc3 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: succeed
3af044e 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: succeeds
1c29b89 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: successfully
70f2347 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: supported
5ae5139 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: that the
8801881 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: the user for membership
2bf04a8 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: the
47c5c2a 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: there are
beff736 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: todo
9dea6eb 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: transport
9cd294f 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: updating
71a01c0 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: will
e6fcc92 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vicancy vicancy vicancy left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jsoref @vicancy