You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
PR #2686 added a new azmcp advisor recommendation apply command that returns IaaC rules (ARM/Terraform) for applying Advisor recommendations to a specific Azure resource type. The command requires a --resource parameter that accepts only a specific set of valid resource type identifiers.
Gaps Found
The --resource parameter documentation in azmcp-commands.md shows --resource <resource> but provides no description of what values are valid. The command validates against a hard-coded list of ~20 resource types, and users have no way to discover valid values without getting an error or reading source code.
The valid resource type identifiers (e.g., compute_virtualmachines, storage_storageaccounts) do not follow a pattern users would intuitively guess, making the parameter especially difficult to use without documentation.
Files to Update
servers/Azure.Mcp.Server/docs/azmcp-commands.md
Context
The RecommendationApplyCommand.cs validates --resource against an embedded resource list. The 20 supported resource type values are:
servers/Azure.Mcp.Server/docs/azmcp-commands.md — must include:
A global options table at the top (subscription, resource-group, tenant, retry-max-retries, retry-delay)
One section per command containing a description and example usage block
Step 3: Validate
Run these commands in order:
dotnet build servers/Azure.Mcp.Server/ — confirms the server project compiles cleanly
dotnet build tools/Azure.Mcp.Tools.Advisor/src/ — confirms the affected toolset compiles
dotnet test tools/Azure.Mcp.Tools.Advisor/tests/Azure.Mcp.Tools.Advisor.Tests/ --filter "TestType!=Live" — runs unit tests
.\eng\common\spelling\Invoke-Cspell.ps1 — checks spelling in new or modified documentation
Next Steps
Tip
Ready for automated implementation? Assign this issue to @copilot to have Copilot coding agent implement the changes described in the Implementation Guide above
Documentation Gap
Server:
Azure.Mcp.ServerTool directory:
tools/Azure.Mcp.Tools.AdvisorTriggered by: 9fca387 (PR #2686) by
@ankiga-MSFTChanged files:
tools/Azure.Mcp.Tools.Advisor/src/Commands/Recommendation/RecommendationApplyCommand.cs(new)servers/Azure.Mcp.Server/docs/azmcp-commands.md(modified)servers/Azure.Mcp.Server/docs/e2eTestPrompts.md(modified)servers/Azure.Mcp.Server/README.md(modified)What Changed
PR #2686 added a new
azmcp advisor recommendation applycommand that returns IaaC rules (ARM/Terraform) for applying Advisor recommendations to a specific Azure resource type. The command requires a--resourceparameter that accepts only a specific set of valid resource type identifiers.Gaps Found
--resourceparameter documentation inazmcp-commands.mdshows--resource <resource>but provides no description of what values are valid. The command validates against a hard-coded list of ~20 resource types, and users have no way to discover valid values without getting an error or reading source code.compute_virtualmachines,storage_storageaccounts) do not follow a pattern users would intuitively guess, making the parameter especially difficult to use without documentation.Files to Update
servers/Azure.Mcp.Server/docs/azmcp-commands.mdContext
The
RecommendationApplyCommand.csvalidates--resourceagainst an embedded resource list. The 20 supported resource type values are:Current docs entry:
📐 Implementation Guide
This section contains step-by-step instructions for a coding agent to implement the changes described above.
Step 1: Modify files
File:
servers/Azure.Mcp.Server/docs/azmcp-commands.mdAction: Edit
In the
### Azure Advisor Operationssection, expand theazmcp advisor recommendation applyentry to document the valid--resourcevalues. Replace:With:
Step 2: Verify documentation structure
servers/Azure.Mcp.Server/docs/azmcp-commands.md— must include:Step 3: Validate
Run these commands in order:
dotnet build servers/Azure.Mcp.Server/— confirms the server project compiles cleanlydotnet build tools/Azure.Mcp.Tools.Advisor/src/— confirms the affected toolset compilesdotnet test tools/Azure.Mcp.Tools.Advisor/tests/Azure.Mcp.Tools.Advisor.Tests/ --filter "TestType!=Live"— runs unit tests.\eng\common\spelling\Invoke-Cspell.ps1— checks spelling in new or modified documentationNext Steps
Tip
Ready for automated implementation? Assign this issue to
@copilotto have Copilot coding agent implement the changes described in the Implementation Guide above