Fix provisioning error reporting, query param merging and bicep baseName default

Author: Shreya Sangwa

tools/Azure.Mcp.Tools.ManagedCleanroom/src/Services/ManagedCleanroomService.cs

@@ -180,7 +180,16 @@ await armClient.GetGenericResources()
 
         stopwatch.Stop();
         var elapsed = stopwatch.Elapsed;
-        var message = $"Collaboration provisioning {provisioningState.ToLowerInvariant()} after " +
+
+        if (provisioningState is "Failed" or "Canceled")
+        {
+            throw new InvalidOperationException(
+                $"Collaboration provisioning {provisioningState.ToLowerInvariant()} after " +
+                $"{(int)elapsed.TotalMinutes}m {elapsed.Seconds}s. " +
+                $"Properties: {properties}");
+        }
+
+        var message = $"Collaboration provisioning succeeded after " +
             $"{(int)elapsed.TotalMinutes}m {elapsed.Seconds}s " +
             "(expected ~25 minutes).";
 
@@ -211,7 +220,11 @@ private static Uri BuildCollaborationsListUri(Uri endpointUri, bool? activeOnly)
 
         if (activeOnly.HasValue)
         {
-            builder.Query = $"activeOnly={activeOnly.Value.ToString().ToLowerInvariant()}";
+            var existingQuery = endpointUri.Query.TrimStart('?');
+            var activeOnlyParam = $"activeOnly={activeOnly.Value.ToString().ToLowerInvariant()}";
+            builder.Query = string.IsNullOrEmpty(existingQuery)
+                ? activeOnlyParam
+                : $"{existingQuery}&{activeOnlyParam}";
         }
 
         return builder.Uri;

tools/Azure.Mcp.Tools.ManagedCleanroom/tests/test-resources.bicep

@@ -2,8 +2,8 @@ targetScope = 'resourceGroup'
 
 @minLength(3)
 @maxLength(24)
-@description('The base resource name.')
-param baseName string = resourceGroup().name
+@description('The base resource name. Must be between 3 and 24 characters.')
+param baseName string
 
 @description('The location of the resource. By default, this is the same as the resource group.')
 param location string = resourceGroup().location