Summary
ArgoCD currently logs IPs based on the requesting client IP. This is problematic when a reverse proxy is in front of ArgoCD as the actual client IP gets hidden. With X-Forwarded-For the proxy attaches a header which contains the client IP which can later be used by the server to correctly log the clients IP.
https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Headers/X-Forwarded-For
Motivation
We require for compliance reasons that all requests are logged with the real client IP.
Proposal
The HTTP part should be relatively easy as there is already ProxyHeaders handler for gorilla.
I don't have enough gRPC knowledge to give advice how this could be implemented.
Summary
ArgoCD currently logs IPs based on the requesting client IP. This is problematic when a reverse proxy is in front of ArgoCD as the actual client IP gets hidden. With X-Forwarded-For the proxy attaches a header which contains the client IP which can later be used by the server to correctly log the clients IP.
https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Headers/X-Forwarded-For
Motivation
We require for compliance reasons that all requests are logged with the real client IP.
Proposal
The HTTP part should be relatively easy as there is already
ProxyHeadershandler for gorilla.I don't have enough gRPC knowledge to give advice how this could be implemented.